-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hold on to empty strings passed to getByLabel [9_4] #25420
Do not hold on to empty strings passed to getByLabel [9_4] #25420
Conversation
When using PyROOT, the string addresses passed to getByLabel are temporary so we can not hold onto the address even for empty strings.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_9_4_X. It involves the following packages: DataFormats/FWLite @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test |
The tests are being triggered in jenkins. |
backport #25421 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 it should solve #25416 |
When using PyROOT, the string addresses passed to getByLabel are
temporary so we can not hold onto the address even for empty strings.